[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264695#comment-16264695
]
ASF GitHub Bot commented on FLINK-7406:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r152853208
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -572,20 +560,53 @@ void addExclusiveBuffer(Buffer buffer) {
exclusiveBuffers.add(buffer);
}
- Buffer takeExclusiveBuffer() {
- return exclusiveBuffers.poll();
- }
-
void addFloatingBuffer(Buffer buffer) {
floatingBuffers.add(buffer);
}
- Buffer takeFloatingBuffer() {
- return floatingBuffers.poll();
+ /**
+ * Add the exclusive buffer into the queue, and recycle one
floating buffer if the
+ * number of available buffers in queue is more than required
amount.
+ *
+ * @param buffer The exclusive buffer of this channel.
+ * @return Whether to recycle one floating buffer.
+ */
+ boolean maintainTargetSize(Buffer buffer) {
--- End diff --
actually, this is now offering two functionalities:
```
addExclusiveBuffer(buffer);
maintainTargetSize(numRequiredBuffers);
```
I'd suggest to either use the two separately or integrate the target size
maintaining into `addExclusiveBuffers`. In any case, you should make
`AvailableBufferQueue` a `static` inner class which could then also be tested
separately.
> Implement Netty receiver incoming pipeline for credit-based
> -----------------------------------------------------------
>
> Key: FLINK-7406
> URL: https://issues.apache.org/jira/browse/FLINK-7406
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> Currently {{PartitionRequestClientHandler}} receives and reads
> {{BufferResponse}} from producer. It will request buffer from {{BufferPool}}
> for holding the message. If not got, the message is staged temporarily and
> {{autoread}} for channel is set false.
> For credit-based mode, {{PartitionRequestClientHandler}} can always get
> buffer from {{RemoteInputChannel}} for reading messages from producer.
> The related works are:
> * Add the backlog of producer in {{BufferResponse}} message structure
> * {{PartitionRequestClientHandler}} requests buffer from
> {{RemoteInputChannel}} directly
> * {{PartitionRequestClientHandler}} updates backlog for
> {{RemoteInputChannel}}, and it may trigger requests of floating buffers from
> {{BufferPool}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
