Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r152861029
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
---
@@ -440,21 +476,25 @@ public void testFairDistributionFloatingBuffers()
throws Exception {
@Test
public void testConcurrentOnSenderBacklogAndRelease() throws Exception {
// Setup
- final NetworkBufferPool networkBufferPool = new
NetworkBufferPool(256, 32, MemoryType.HEAP);
+ final NetworkBufferPool networkBufferPool = new
NetworkBufferPool(130, 32, MemoryType.HEAP);
+ final int numExclusiveBuffers = 2;
+ final int numFloatingBuffers = 128;
+
final ExecutorService executor =
Executors.newFixedThreadPool(2);
+
final SingleInputGate inputGate = createSingleInputGate();
final RemoteInputChannel inputChannel =
createRemoteInputChannel(inputGate);
inputGate.setInputChannel(inputChannel.partitionId.getPartitionId(),
inputChannel);
try {
- final BufferPool bufferPool =
networkBufferPool.createBufferPool(128, 128);
+ final BufferPool bufferPool =
networkBufferPool.createBufferPool(numFloatingBuffers, numFloatingBuffers);
inputGate.setBufferPool(bufferPool);
- inputGate.assignExclusiveSegments(networkBufferPool, 2);
+ inputGate.assignExclusiveSegments(networkBufferPool,
numExclusiveBuffers);
- final Callable<Void> requestBufferTask = new
Callable<Void>() {
+ final Callable requestBufferTask = new Callable<Void>()
{
--- End diff --
please keep `Callable<Void>` (or replace by a lambda)
---
