[GitHub] flink pull request #4940: [FLINK-7959] [table] Split CodeGenerator into Code...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4940#discussion_r152921238
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenUtils.scala
 ---
    @@ -203,6 +210,569 @@ object CodeGenUtils {
           throw new CodeGenException("Integer expression type expected.")
         }
     
    +  def generateNullLiteral(
    --- End diff --
    
    Actually these methods should be part of the `ExprCodeGenerator`. They are 
more than just utils but the actual main logic.


---