[ https://issues.apache.org/jira/browse/FLINK-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266558#comment-16266558 ]
ASF GitHub Bot commented on FLINK-4822: --------------------------------------- Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5050#discussion_r153141260 --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/PeriodicOffsetCommitter.java --- @@ -45,14 +45,18 @@ /** Flag to mark the periodic committer as running. */ private volatile boolean running = true; + /** The task info to register in zk ownership path. */ + private final String taskId; + PeriodicOffsetCommitter(ZookeeperOffsetHandler offsetHandler, List<KafkaTopicPartitionState<TopicAndPartition>> partitionStates, ExceptionProxy errorHandler, - long commitInterval) { + long commitInterval, String taskId) { --- End diff -- Please list this parameter on a separate new line for consistently code style. > Ensure that the Kafka 0.8 connector is compatible with > kafka-consumer-groups.sh > ------------------------------------------------------------------------------- > > Key: FLINK-4822 > URL: https://issues.apache.org/jira/browse/FLINK-4822 > Project: Flink > Issue Type: Bug > Components: Kafka Connector > Reporter: Robert Metzger > > The Kafka 0.8 connector is not properly creating all datastructures in > Zookeeper for Kafka's {{kafka-consumer-groups.sh}} tool. > A user reported the issue here: > http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Flink-Kafka-connector08-not-updating-the-offsets-with-the-zookeeper-td9469.html#a9498 > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+data+structures+in+Zookeeper -- This message was sent by Atlassian JIRA (v6.4.14#64029)