[
https://issues.apache.org/jira/browse/FLINK-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266765#comment-16266765
]
ASF GitHub Bot commented on FLINK-7530:
---------------------------------------
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5081
[FLINK-7530][flip6] Migrate TaskManagerMetricsHandler to new
RestServerEndpoint
## What is the purpose of the change
*FLIP-6 efforts: Migrating HTTP handlers*
## Brief change log
- Migrate logic from
`org.apache.flink.runtime.rest.handler.legacy.metrics.TaskManagerMetricsHandler
to` new handler.
- Add new handler to `DispatcherRestEndpoint`.
## Verifying this change
- *Added unit tests for all new classes and modified existing classes
except for DispatcherRestEndpoint.*
- *Manually deployed a job locally and verified with `curl` that
TaskManager metrics can be queried in FLIP-6 standalone mode. Note that the
task manager ids exposed by the WebUI in FLIP-6 mode are currently broken
(https://issues.apache.org/jira/browse/FLINK-8150). I had to obtain valid ids
by setting a breakpoint in `ResourceManager`*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
CC: @tillrohrmann
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink FLINK-7530-tm-metrics
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5081.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5081
----
commit 71ee76139e0703bea74623353c7175533582aa16
Author: gyao <[email protected]>
Date: 2017-11-27T12:57:48Z
[FLINK-7530][flip6] Migrate TaskManagerMetricsHandler to new
RestServerEndpoint
Migrate logic in
org.apache.flink.runtime.rest.handler.legacy.metrics.TaskManagerMetricsHandler
to new handler, and add new handler to DispatcherRestEndpoint.
----
> Port existing REST handlers to support Flip-6 components
> --------------------------------------------------------
>
> Key: FLINK-7530
> URL: https://issues.apache.org/jira/browse/FLINK-7530
> Project: Flink
> Issue Type: New Feature
> Components: Distributed Coordination, REST, Webfrontend
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> This is the umbrella issue for porting the existing REST handlers to work
> together with the new {{RestServerEndpoint}} and the {{AbstractRestHandler}}.
> This is the requirement to make them work with the Flip-6 {{Dispatcher}} and
> {{JobMaster}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
