[
https://issues.apache.org/jira/browse/FLINK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268514#comment-16268514
]
ASF GitHub Bot commented on FLINK-8151:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5070#discussion_r153448795
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala
---
@@ -188,13 +188,6 @@ object ScalarOperators {
(leftTerm, rightTerm) => s"java.util.Arrays.equals($leftTerm,
$rightTerm)"
}
}
- // map types
- else if (isMap(left.resultType) &&
- left.resultType.getTypeClass == right.resultType.getTypeClass) {
- generateOperatorIfNotNull(nullCheck, BOOLEAN_TYPE_INFO, left, right)
{
- (leftTerm, rightTerm) => s"java.util.Map.equals($leftTerm,
$rightTerm)"
--- End diff --
Do we really need to remove the entire functionality? Wouldn't be
`$leftTerm.equals($rightTerm)` be enough?
> [Table] removing map value equality check
> -----------------------------------------
>
> Key: FLINK-8151
> URL: https://issues.apache.org/jira/browse/FLINK-8151
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Rong Rong
> Assignee: Rong Rong
>
> Following up with FLINK-8038. The equality check is not working as Map does
> not support element-wise equality. Suggest to remove it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
