[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268591#comment-16268591
]
ASF GitHub Bot commented on FLINK-7416:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153456963
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -145,19 +171,29 @@ public void testReceiveBuffer() throws Exception {
*/
@Test
public void testThrowExceptionForNoAvailableBuffer() throws Exception {
- final RemoteInputChannel inputChannel =
mock(RemoteInputChannel.class);
- when(inputChannel.getInputChannelId()).thenReturn(new
InputChannelID());
- when(inputChannel.requestBuffer()).thenReturn(null);
+ final NetworkBufferPool networkBufferPool = new
NetworkBufferPool(10, 32, MemoryType.HEAP);
+ final SingleInputGate inputGate = createSingleInputGate();
+ final RemoteInputChannel inputChannel =
spy(createRemoteInputChannel(inputGate));
+
inputGate.setInputChannel(inputChannel.getPartitionId().getPartitionId(),
inputChannel);
+ try {
+ inputGate.assignExclusiveSegments(networkBufferPool, 1);
- final BufferResponse bufferResponse = createBufferResponse(
- TestBufferFactory.createBuffer(), 0,
inputChannel.getInputChannelId(), 2);
+ final BufferResponse bufferResponse =
createBufferResponse(
+ inputChannel.requestBuffer(), 0,
inputChannel.getInputChannelId(), 2);
- final CreditBasedClientHandler client = new
CreditBasedClientHandler();
- client.addInputChannel(inputChannel);
+ final CreditBasedClientHandler handler = new
CreditBasedClientHandler();
+ handler.addInputChannel(inputChannel);
+
+ handler.channelRead(mock(ChannelHandlerContext.class),
bufferResponse);
- client.channelRead(mock(ChannelHandlerContext.class),
bufferResponse);
+ verify(inputChannel,
times(1)).onError(any(IllegalStateException.class));
+ } finally {
+ // Release all the buffer resources
+ inputChannel.releaseAllResources();
--- End diff --
call `inputGate.releaseAllResources();` instead
> Implement Netty receiver outgoing pipeline for credit-based
> -----------------------------------------------------------
>
> Key: FLINK-7416
> URL: https://issues.apache.org/jira/browse/FLINK-7416
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> The related works are :
> * We define a new message called {{AddCredit}} to notify the incremental
> credit during data shuffle.
> * Whenever an {{InputChannel}}’s unannounced credit goes up from zero, the
> channel is enqueued in the pipeline.
> * Whenever the channel becomes writable, it takes the next {{InputChannel}}
> and sends its unannounced credit. The credit is reset to zero after each sent.
> * That way, messages are sent as often as the network has capacity and
> contain as much credit as available for the channel at that point in time.
> Otherwise, it would only add latency to the announcements and not increase
> throughput.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
