Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4559#discussion_r153564111
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CancelPartitionRequestTest.java
 ---
    @@ -174,19 +175,21 @@ public ResultSubpartitionView answer(InvocationOnMock 
invocationOnMock) throws T
     
        // 
---------------------------------------------------------------------------------------------
     
    -   static class InfiniteSubpartitionView implements ResultSubpartitionView 
{
    +   static class InfiniteSubpartitionView extends ResultSubpartitionView {
     
                private final BufferProvider bufferProvider;
     
                private final CountDownLatch sync;
     
                public InfiniteSubpartitionView(BufferProvider bufferProvider, 
CountDownLatch sync) {
    +                   super(mock(ResultSubpartition.class));
    +
                        this.bufferProvider = checkNotNull(bufferProvider);
                        this.sync = checkNotNull(sync);
                }
     
                @Override
    -           public Buffer getNextBuffer() throws IOException, 
InterruptedException {
    +           public Buffer getNextBufferInternal() throws IOException, 
InterruptedException {
    --- End diff --
    
    make this `protected`


---

Reply via email to