[
https://issues.apache.org/jira/browse/FLINK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271417#comment-16271417
]
ASF GitHub Bot commented on FLINK-8151:
---------------------------------------
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5070
@twalthr I think my previous unit test method was not correct. Since
TableAPI always use `java.util.HashMap` per flink documentation. I think it is
safe to directly use `$leftTerm.equals($rightTerm)` and it should always be
using `java.util.AbstractMap.equals` implementation. Do you think I should add
extra check or do you think the `isMap(resultType)` should be suffice?
> [Table] Map equality check to use entrySet equality
> ---------------------------------------------------
>
> Key: FLINK-8151
> URL: https://issues.apache.org/jira/browse/FLINK-8151
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Rong Rong
> Assignee: Rong Rong
>
> Following up with FLINK-8038. The equality check currently is broken. Plan to
> support element-wise equality check by always using the base class:
> "java.util.Map.equals" method.
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
