Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154316689
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -170,29 +172,20 @@ public void testReceiveBuffer() throws Exception {
*/
@Test
public void testThrowExceptionForNoAvailableBuffer() throws Exception {
- final NetworkBufferPool networkBufferPool = new
NetworkBufferPool(10, 32);
final SingleInputGate inputGate = createSingleInputGate();
final RemoteInputChannel inputChannel =
spy(createRemoteInputChannel(inputGate));
-
inputGate.setInputChannel(inputChannel.getPartitionId().getPartitionId(),
inputChannel);
- try {
- inputGate.assignExclusiveSegments(networkBufferPool, 1);
-
- final BufferResponse bufferResponse =
createBufferResponse(
- inputChannel.requestBuffer(), 0,
inputChannel.getInputChannelId(), 2);
- final CreditBasedClientHandler handler = new
CreditBasedClientHandler();
- handler.addInputChannel(inputChannel);
+ final CreditBasedClientHandler handler = new
CreditBasedClientHandler();
+ handler.addInputChannel(inputChannel);
- handler.channelRead(mock(ChannelHandlerContext.class),
bufferResponse);
+ assertEquals("There should be no buffers available in the
channel.",
+ 0, inputChannel.getNumberOfAvailableBuffers());
- verify(inputChannel,
times(1)).onError(any(IllegalStateException.class));
- } finally {
- // Release all the buffer resources
- inputChannel.releaseAllResources();
+ final BufferResponse bufferResponse = createBufferResponse(
+ TestBufferFactory.createBuffer(), 0,
inputChannel.getInputChannelId(), 2);
+ handler.channelRead(mock(ChannelHandlerContext.class),
bufferResponse);
- networkBufferPool.destroyAllBufferPools();
- networkBufferPool.destroy();
- }
+ verify(inputChannel,
times(1)).onError(any(IllegalStateException.class));
--- End diff --
nice test simplification
---
