[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274365#comment-16274365
]
ASF GitHub Bot commented on FLINK-7416:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154316689
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -170,29 +172,20 @@ public void testReceiveBuffer() throws Exception {
*/
@Test
public void testThrowExceptionForNoAvailableBuffer() throws Exception {
- final NetworkBufferPool networkBufferPool = new
NetworkBufferPool(10, 32);
final SingleInputGate inputGate = createSingleInputGate();
final RemoteInputChannel inputChannel =
spy(createRemoteInputChannel(inputGate));
-
inputGate.setInputChannel(inputChannel.getPartitionId().getPartitionId(),
inputChannel);
- try {
- inputGate.assignExclusiveSegments(networkBufferPool, 1);
-
- final BufferResponse bufferResponse =
createBufferResponse(
- inputChannel.requestBuffer(), 0,
inputChannel.getInputChannelId(), 2);
- final CreditBasedClientHandler handler = new
CreditBasedClientHandler();
- handler.addInputChannel(inputChannel);
+ final CreditBasedClientHandler handler = new
CreditBasedClientHandler();
+ handler.addInputChannel(inputChannel);
- handler.channelRead(mock(ChannelHandlerContext.class),
bufferResponse);
+ assertEquals("There should be no buffers available in the
channel.",
+ 0, inputChannel.getNumberOfAvailableBuffers());
- verify(inputChannel,
times(1)).onError(any(IllegalStateException.class));
- } finally {
- // Release all the buffer resources
- inputChannel.releaseAllResources();
+ final BufferResponse bufferResponse = createBufferResponse(
+ TestBufferFactory.createBuffer(), 0,
inputChannel.getInputChannelId(), 2);
+ handler.channelRead(mock(ChannelHandlerContext.class),
bufferResponse);
- networkBufferPool.destroyAllBufferPools();
- networkBufferPool.destroy();
- }
+ verify(inputChannel,
times(1)).onError(any(IllegalStateException.class));
--- End diff --
nice test simplification
> Implement Netty receiver outgoing pipeline for credit-based
> -----------------------------------------------------------
>
> Key: FLINK-7416
> URL: https://issues.apache.org/jira/browse/FLINK-7416
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> The related works are :
> * We define a new message called {{AddCredit}} to notify the incremental
> credit during data shuffle.
> * Whenever an {{InputChannel}}’s unannounced credit goes up from zero, the
> channel is enqueued in the pipeline.
> * Whenever the channel becomes writable, it takes the next {{InputChannel}}
> and sends its unannounced credit. The credit is reset to zero after each sent.
> * That way, messages are sent as often as the network has capacity and
> contain as much credit as available for the channel at that point in time.
> Otherwise, it would only add latency to the announcements and not increase
> throughput.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
