[
https://issues.apache.org/jira/browse/FLINK-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276749#comment-16276749
]
ASF GitHub Bot commented on FLINK-8193:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5118
[FLINK-8193][quickstart] Cleanup quickstart poms
## What is the purpose of the change
This PR addresses 2 problems in the quick start poms:
1) The poms declared unused dependencies (flink-clients), and were missing
used dependencies (flink-core, scala-library).
2) The manual dependency exclusion using the maven-shade-plugin was prone
to being out-dated.
This PR fixes the missing/unused dependencies, and removes the manual
exclusion so there is now only one correct way of building the jar, which is
using the `build-jar` profile.
## Verifying this change
This change was verified locally. I installed the archetypes locally and
created new projects from them.
For verification I executed the programs in the IDE and packaged the jar
with the `build-jar` profile and checked whether that they don't contain any
dependencies.
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (docs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 8193
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5118.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5118
----
commit 0f9697fdb4efb129458139d2fafbf20cc1faaa23
Author: zentol <[email protected]>
Date: 2017-12-04T12:38:17Z
add missing / remove unused dependencies
commit f87b140083d253ffcb453f97aabf90fbfcb59098
Author: zentol <[email protected]>
Date: 2017-12-04T12:38:33Z
Remove manual shading exclusion rules
----
> Rework quickstart exclusions
> ----------------------------
>
> Key: FLINK-8193
> URL: https://issues.apache.org/jira/browse/FLINK-8193
> Project: Flink
> Issue Type: Improvement
> Components: Build System, Quickstarts
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
>
> The quickstart poms currently contain 2 entirely separate dependency
> exclusion mechanisms:
> A) manual exclusions of dependencies (including transitive dependencies) via
> the {{artifactSet}} of the {{maven-shade-plugin}}
> B) automatic inclusion by marking dependencies as {{<provided>}} with the
> {{build-jar}} profile
> I propose removing A) entirely. By default, all dependencies will be included
> in the jar to allow execution in the IDE (which setting all dependencies to
> provided would not). To execute things on a cluster we now always refer to
> Option B), which is trivial to maintain and also reliable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
