Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154710187
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -378,6 +381,11 @@ public void notifyBufferDestroyed() {
// Nothing to do actually.
}
+ @VisibleForTesting
+ public void increaseCredit(int credit) {
--- End diff --
It is no problem to increase credit by either `BufferResponse` or `recycle`
methods.
The only concern is the way to trigger `notifyCreditAvailable`. I think it
may still need to trigger by calling
`CreditBasedClientHandler#notifyCreditAvailable` explicitly. The common trigger
way seems not work currently via `RemoteInputChannle` ->
`PartitionRequestClient` -> `PartitionRequestClientHandler` because the
`PartitionRequestClient` is still tied to the old
`PartitionRequestClientHandler`.
---
