[
https://issues.apache.org/jira/browse/FLINK-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278224#comment-16278224
]
ASF GitHub Bot commented on FLINK-8007:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5098#discussion_r154880974
--- Diff: flink-metrics/flink-metrics-datadog/pom.xml ---
@@ -88,6 +65,7 @@ under the License.
<goal>shade</goal>
</goals>
<configuration>
+
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
--- End diff --
This is a cleaner approach compared to listing transitive dependencies. We
never had a dependency on `okio`; it was only defined to be included in the
shaded jar. Promoting transitive dependencies accomplishes the same thing,
without the maintainability issues that arise when you bump the version of a
dependency.
> Move TestMeter class to test scope
> ----------------------------------
>
> Key: FLINK-8007
> URL: https://issues.apache.org/jira/browse/FLINK-8007
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Trivial
> Fix For: 1.5.0
>
>
> The TestMeter class in flink-metrics-core is only for test purposes, but is
> not located in the test src directory.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
