[ 
https://issues.apache.org/jira/browse/FLINK-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278453#comment-16278453
 ] 

ASF GitHub Bot commented on FLINK-8200:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5122#discussion_r154925706
  
    --- Diff: 
flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBAsyncSnapshotTest.java
 ---
    @@ -333,7 +339,7 @@ public void testCleanupOfSnapshotsInFailureCase() 
throws Exception {
     
                RocksDBStateBackend backend = new 
RocksDBStateBackend(stateBackend);
     
    -           backend.setDbStoragePath("file:///tmp/foobar");
    +           backend.setDbStoragePath("file://" + 
temporaryFolder.newFolder().getAbsolutePath());
    --- End diff --
    
    To make this cross compatible with Windows (and other OSs), can you change 
that to 
`backend.setDbStoragePath(temporaryFolder.newFolder().toUri().toString());`


> RocksDBAsyncSnapshotTest should use temp fold instead of fold with fixed name
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-8200
>                 URL: https://issues.apache.org/jira/browse/FLINK-8200
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Wenlong Lyu
>            Assignee: Wenlong Lyu
>
> The following case failed when different user run the test in the same 
> machine.
> Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.226 sec <<< 
> FAILURE! - in 
> org.apache.flink.contrib.streaming.state.RocksDBAsyncSnapshotTest
> testCleanupOfSnapshotsInFailureCase(org.apache.flink.contrib.streaming.state.RocksDBAsyncSnapshotTest)
>   Time elapsed: 0.023 sec  <<< ERROR!
> java.io.IOException: No local storage directories available. Local DB files 
> directory 'file:/tmp/foobar' does not exist and cannot be created.
>     at 
> org.apache.flink.contrib.streaming.state.RocksDBStateBackend.lazyInitializeForJob(RocksDBStateBackend.java:251)
>     at 
> org.apache.flink.contrib.streaming.state.RocksDBStateBackend.createKeyedStateBackend(RocksDBStateBackend.java:300)
>     at 
> org.apache.flink.contrib.streaming.state.RocksDBAsyncSnapshotTest.testCleanupOfSnapshotsInFailureCase(RocksDBAsyncSnapshotTest.java:338)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to