[
https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278655#comment-16278655
]
ASF GitHub Bot commented on FLINK-7878:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4911#discussion_r154964117
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
---
@@ -61,18 +81,17 @@
/** How many state size in mb are used */
private final int stateSizeInMB;
+ private final Map<String, Resource> extendedResources = new
HashMap<>(1);
+
/**
* Creates a new ResourceSpec with basic common resources.
*
* @param cpuCores The number of CPU cores (possibly fractional, i.e.,
0.2 cores)
* @param heapMemoryInMB The size of the java heap memory, in megabytes.
+ * @param extendedResources The extended resources, associated with the
resource manager used
*/
- public ResourceSpec(double cpuCores, int heapMemoryInMB) {
- this.cpuCores = cpuCores;
- this.heapMemoryInMB = heapMemoryInMB;
- this.directMemoryInMB = 0;
- this.nativeMemoryInMB = 0;
- this.stateSizeInMB = 0;
+ public ResourceSpec(double cpuCores, int heapMemoryInMB, Resource...
extendedResources) {
+ this(cpuCores, heapMemoryInMB, 0, 0, 0, extendedResources);
--- End diff --
Let's remove this constructor.
> Extend the resource type user can define in ResourceSpec
> --------------------------------------------------------
>
> Key: FLINK-7878
> URL: https://issues.apache.org/jira/browse/FLINK-7878
> Project: Flink
> Issue Type: Improvement
> Components: DataSet API, DataStream API
> Reporter: shuai.xu
> Assignee: shuai.xu
> Labels: flip-6
>
> Now, flink only support user define how much CPU and MEM used in an operator,
> but now the resource in a cluster is various. For example, an application for
> image processing may need GPU, some others may need FPGA.
> Only CPU and MEM is not enough, and the resource type is becoming more and
> more, so we need to make the ResourSpec extendible.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
