Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4911#discussion_r154964117
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
 ---
    @@ -61,18 +81,17 @@
        /** How many state size in mb are used */
        private final int stateSizeInMB;
     
    +   private final Map<String, Resource> extendedResources = new 
HashMap<>(1);
    +
        /**
         * Creates a new ResourceSpec with basic common resources.
         *
         * @param cpuCores The number of CPU cores (possibly fractional, i.e., 
0.2 cores)
         * @param heapMemoryInMB The size of the java heap memory, in megabytes.
    +    * @param extendedResources The extended resources, associated with the 
resource manager used
         */
    -   public ResourceSpec(double cpuCores, int heapMemoryInMB) {
    -           this.cpuCores = cpuCores;
    -           this.heapMemoryInMB = heapMemoryInMB;
    -           this.directMemoryInMB = 0;
    -           this.nativeMemoryInMB = 0;
    -           this.stateSizeInMB = 0;
    +   public ResourceSpec(double cpuCores, int heapMemoryInMB, Resource... 
extendedResources) {
    +           this(cpuCores, heapMemoryInMB, 0, 0, 0, extendedResources);
    --- End diff --
    
    Let's remove this constructor.


---

Reply via email to