[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5065#discussion_r154967459
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
 ---
    @@ -411,6 +411,7 @@ abstract class TableEnvironment(val config: 
TableConfig) {
         }
     
         checkValidTableName(name)
    +    checkValidTableType(table)
    --- End diff --
    
    I would call this method `validateInputTypes` and rename 
`org.apache.flink.table.api.TableEnvironment#validateType` to 
`validateOutputTypes`.


---