[
https://issues.apache.org/jira/browse/FLINK-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278868#comment-16278868
]
ASF GitHub Bot commented on FLINK-8085:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155012983
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -331,8 +334,19 @@ public void setInitialState(TaskStateSnapshot
checkpointStateHandles) {
*
* @return A future for the execution's termination
*/
- public CompletableFuture<ExecutionState> getTerminationFuture() {
- return terminationFuture;
+ @Override
+ public CompletableFuture<ExecutionState> getTerminalStateFuture() {
+ return terminalStateFuture;
+ }
+
+ /**
+ * Gets the release future which is completed once the execution
reaches a terminal
+ * state and the assigned resource has been released.
+ *
+ * @return
--- End diff --
`@return` tag can be removed.
> Thin out the LogicalSlot interface
> ----------------------------------
>
> Key: FLINK-8085
> URL: https://issues.apache.org/jira/browse/FLINK-8085
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Labels: flip-6
>
> The {{LogicalSlot}} interface contains method which we don't strictly need
> (e.g. {{isCanceled}}, {{isReleased}}). Moreover, we should decouple the
> {{LogicalSlot}} from the {{Execution}} by only setting the
> {{ExecutionAttemptID}} instead of {{Execution}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
