Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155015331
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerIsolatedTasksTest.java
---
@@ -294,11 +297,11 @@ public void testScheduleWithDyingInstances() {
i2.markDead();
- for (SimpleSlot slot : slots) {
- if (slot.getOwner() == i2) {
- assertTrue(slot.isCanceled());
+ for (LogicalSlot slot : slots) {
+ if
(Objects.equals(slot.getTaskManagerLocation().getResourceID(),
i2.getTaskManagerID())) {
--- End diff --
I think `slot.getTaskManagerLocation().getResourceID()` cannot return null.
Is there a need to use `Objects.equals`?
---
