Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155279729
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java ---
@@ -312,24 +312,36 @@ public void returnAllocatedSlot(Slot slot) {
// (1) do we have a slot available already?
SlotAndLocality slotFromPool = availableSlots.poll(resources,
locationPreferences);
if (slotFromPool != null) {
- SimpleSlot slot = createSimpleSlot(slotFromPool.slot(),
slotFromPool.locality());
--- End diff --
Method `createSimpleSlot` is no longer in use.
---
