[
https://issues.apache.org/jira/browse/FLINK-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280441#comment-16280441
]
ASF GitHub Bot commented on FLINK-7749:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/5127
[FLINK-7749][network] refactor the ResultPartitionWriter into an interface
## What is the purpose of the change
After moving task event notification into the `TaskEventDispatcher`
(#4761), this PR finally makes the `ResultPartitionWriter` wrapper an interface.
## Brief change log
- change `ResultPartitionWriter` from a wrapper to an interface
- adapt usages & clean up duplication of `ResultPartitionWriter` and
`ResultPartition`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7749-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5127.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5127
----
----
> Refactor the ResultPartitionWriter into an interface
> ----------------------------------------------------
>
> Key: FLINK-7749
> URL: https://issues.apache.org/jira/browse/FLINK-7749
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> After changing task event notification to the {{TaskEventDispatcher}}
> (FLINK-7746) and buffer writing to {{ResultPartition}} (FLINK-7748), we can
> finally refactor the {{ResultPartitionWriter}} into an interface.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
