Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5130#discussion_r155451196
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/testutils/TestUtils.java
 ---
    @@ -0,0 +1,39 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.kinesis.testutils;
    +
    +import 
org.apache.flink.streaming.connectors.kinesis.config.AWSConfigConstants;
    +
    +import java.util.Properties;
    +
    +/**
    + * General test utils.
    + */
    +public class TestUtils {
    +   /**
    +    * Get properties with Kinesis-required fields.
    +    */
    +   public static Properties getPropertiesWithRequiredFields() {
    --- End diff --
    
    I prefer the name `getStandardProperties` over this one. That makes it a 
bit more coherent with the Kafka test code.


---

Reply via email to