GitHub user bowenli86 opened a pull request:

    https://github.com/apache/flink/pull/5131

    [FLINK-8218] move flink-connector-kinesis examples from /src to /test

    ## What is the purpose of the change
    
    just saw there are runnable examples in src tree and traced back to this 
PR. I feel it's really bad to have runnable examples (with java main method) in 
a lib jar that Flink distributes.
    
    chatted with Gordon, we agreed that we should move those examples from /src 
to /test
    
    ## Brief change log
    
    move examples in flink-connector-kinesis from /src to /test
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
    none
    
    ## Documentation
    
    none

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bowenli86/flink FLINK-8218

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5131
    
----

----


---

Reply via email to