[GitHub] flink issue #5068: [FLINK-8122] [table] Name all built-in table sinks and so...

[xccui]

Github user xccui commented on the issue:

    https://github.com/apache/flink/pull/5068
  
    Thanks for the review @fhueske.
    * I added the `explainSink()` method to make the `TableSink` consistent 
with the `TableSource`. Discarding this method and using the 
`TableConnectorUtil.genRuntimeName()` in each table sink should also be OK.
    * Yes, the test sources and sinks are not exposed. I'll revert them.
    * The source name was set via this call 
`execEnv.createInput(orcIF).name(explainSource())`. The `createInput()` method 
for a **mocked** `execEnv` will return `null` and cause a NPE.
    
    Thanks,
    Xingcan


---