[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

[GJL]

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5091#discussion_r155549755
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/LogicalSlot.java 
---
    @@ -32,6 +34,20 @@
      */
     public interface LogicalSlot {
     
    +    Payload TERMINATED_PAYLOAD = new Payload() {
    +
    +           private final CompletableFuture<?> COMPLETED_TERMINATION_FUTURE 
= CompletableFuture.completedFuture(null);
    --- End diff --
    
    nit: `COMPLETED_TERMINATION_FUTURE` should be camel cased because is not 
actually a constant (not static).


---