[
https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281986#comment-16281986
]
ASF GitHub Bot commented on FLINK-7956:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r155549755
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/LogicalSlot.java
---
@@ -32,6 +34,20 @@
*/
public interface LogicalSlot {
+ Payload TERMINATED_PAYLOAD = new Payload() {
+
+ private final CompletableFuture<?> COMPLETED_TERMINATION_FUTURE
= CompletableFuture.completedFuture(null);
--- End diff --
nit: `COMPLETED_TERMINATION_FUTURE` should be camel cased because is not
actually a constant (not static).
> Add support for scheduling with slot sharing
> --------------------------------------------
>
> Key: FLINK-7956
> URL: https://issues.apache.org/jira/browse/FLINK-7956
> Project: Flink
> Issue Type: Sub-task
> Components: Scheduler
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> In order to reach feature equivalence with the old code base, we should add
> support for scheduling with slot sharing to the {{SlotPool}}. This will also
> allow us to run all the IT cases based on the {{AbstractTestBase}} on the
> Flip-6 {{MiniCluster}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
