[
https://issues.apache.org/jira/browse/FLINK-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283699#comment-16283699
]
ASF GitHub Bot commented on FLINK-8030:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4988#discussion_r155797999
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
---
@@ -0,0 +1,402 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.webmonitor;
+
+import org.apache.flink.api.common.time.Time;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.runtime.resourcemanager.ResourceManagerGateway;
+import org.apache.flink.runtime.rest.RestServerEndpoint;
+import org.apache.flink.runtime.rest.RestServerEndpointConfiguration;
+import org.apache.flink.runtime.rest.handler.RestHandlerConfiguration;
+import org.apache.flink.runtime.rest.handler.RestHandlerSpecification;
+import org.apache.flink.runtime.rest.handler.cluster.ClusterConfigHandler;
+import
org.apache.flink.runtime.rest.handler.cluster.ClusterOverviewHandler;
+import
org.apache.flink.runtime.rest.handler.cluster.DashboardConfigHandler;
+import org.apache.flink.runtime.rest.handler.job.JobAccumulatorsHandler;
+import org.apache.flink.runtime.rest.handler.job.JobConfigHandler;
+import org.apache.flink.runtime.rest.handler.job.JobDetailsHandler;
+import org.apache.flink.runtime.rest.handler.job.JobExceptionsHandler;
+import org.apache.flink.runtime.rest.handler.job.JobIdsHandler;
+import org.apache.flink.runtime.rest.handler.job.JobPlanHandler;
+import
org.apache.flink.runtime.rest.handler.job.JobVertexAccumulatorsHandler;
+import org.apache.flink.runtime.rest.handler.job.JobsOverviewHandler;
+import org.apache.flink.runtime.rest.handler.job.SubtasksTimesHandler;
+import
org.apache.flink.runtime.rest.handler.job.checkpoints.CheckpointConfigHandler;
+import
org.apache.flink.runtime.rest.handler.job.checkpoints.CheckpointStatisticDetailsHandler;
+import
org.apache.flink.runtime.rest.handler.job.checkpoints.CheckpointStatsCache;
+import
org.apache.flink.runtime.rest.handler.job.checkpoints.CheckpointingStatisticsHandler;
+import
org.apache.flink.runtime.rest.handler.job.checkpoints.TaskCheckpointStatisticDetailsHandler;
+import
org.apache.flink.runtime.rest.handler.job.metrics.JobManagerMetricsHandler;
+import org.apache.flink.runtime.rest.handler.job.metrics.JobMetricsHandler;
+import
org.apache.flink.runtime.rest.handler.job.metrics.JobVertexMetricsHandler;
+import
org.apache.flink.runtime.rest.handler.job.metrics.SubtaskMetricsHandler;
+import
org.apache.flink.runtime.rest.handler.job.metrics.TaskManagerMetricsHandler;
+import org.apache.flink.runtime.rest.handler.legacy.ExecutionGraphCache;
+import
org.apache.flink.runtime.rest.handler.legacy.files.StaticFileServerHandler;
+import
org.apache.flink.runtime.rest.handler.legacy.files.WebContentHandlerSpecification;
+import org.apache.flink.runtime.rest.handler.legacy.metrics.MetricFetcher;
+import
org.apache.flink.runtime.rest.handler.taskmanager.TaskManagerDetailsHandler;
+import
org.apache.flink.runtime.rest.handler.taskmanager.TaskManagersHandler;
+import
org.apache.flink.runtime.rest.messages.ClusterConfigurationInfoHeaders;
+import org.apache.flink.runtime.rest.messages.ClusterOverviewHeaders;
+import
org.apache.flink.runtime.rest.messages.DashboardConfigurationHeaders;
+import org.apache.flink.runtime.rest.messages.JobAccumulatorsHeaders;
+import org.apache.flink.runtime.rest.messages.JobConfigHeaders;
+import org.apache.flink.runtime.rest.messages.JobExceptionsHeaders;
+import
org.apache.flink.runtime.rest.messages.JobIdsWithStatusesOverviewHeaders;
+import org.apache.flink.runtime.rest.messages.JobPlanHeaders;
+import org.apache.flink.runtime.rest.messages.JobVertexAccumulatorsHeaders;
+import org.apache.flink.runtime.rest.messages.JobsOverviewHeaders;
+import org.apache.flink.runtime.rest.messages.SubtasksTimesHeaders;
+import
org.apache.flink.runtime.rest.messages.checkpoints.CheckpointConfigHeaders;
+import
org.apache.flink.runtime.rest.messages.checkpoints.CheckpointStatisticDetailsHeaders;
+import
org.apache.flink.runtime.rest.messages.checkpoints.CheckpointingStatisticsHeaders;
+import
org.apache.flink.runtime.rest.messages.checkpoints.TaskCheckpointStatisticsHeaders;
+import org.apache.flink.runtime.rest.messages.job.JobDetailsHeaders;
+import
org.apache.flink.runtime.rest.messages.job.metrics.JobManagerMetricsHeaders;
+import
org.apache.flink.runtime.rest.messages.job.metrics.JobMetricsHeaders;
+import
org.apache.flink.runtime.rest.messages.job.metrics.JobVertexMetricsHeaders;
+import
org.apache.flink.runtime.rest.messages.job.metrics.SubtaskMetricsHeaders;
+import
org.apache.flink.runtime.rest.messages.job.metrics.TaskManagerMetricsHeaders;
+import
org.apache.flink.runtime.rest.messages.taskmanager.TaskManagerDetailsHeaders;
+import
org.apache.flink.runtime.rest.messages.taskmanager.TaskManagersHeaders;
+import org.apache.flink.runtime.webmonitor.retriever.GatewayRetriever;
+import
org.apache.flink.runtime.webmonitor.retriever.MetricQueryServiceRetriever;
+import org.apache.flink.util.FileUtils;
+import org.apache.flink.util.Preconditions;
+
+import
org.apache.flink.shaded.netty4.io.netty.channel.ChannelInboundHandler;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.Executor;
+
+/**
+ * Rest endpoint which serves the web frontend REST calls.
+ *
+ * @param <T> type of the leader gateway
+ */
+public class WebMonitorEndpoint<T extends RestfulGateway> extends
RestServerEndpoint {
+
+ protected final GatewayRetriever<T> leaderRetriever;
+ private final Configuration clusterConfiguration;
+ protected final RestHandlerConfiguration restConfiguration;
+ private final GatewayRetriever<ResourceManagerGateway>
resourceManagerRetriever;
+ private final Executor executor;
+
+ private final ExecutionGraphCache executionGraphCache;
+ private final CheckpointStatsCache checkpointStatsCache;
+
+ private final MetricFetcher<T> metricFetcher;
+
+ public WebMonitorEndpoint(
+ RestServerEndpointConfiguration endpointConfiguration,
+ GatewayRetriever<T> leaderRetriever,
+ Configuration clusterConfiguration,
+ RestHandlerConfiguration restConfiguration,
+ GatewayRetriever<ResourceManagerGateway>
resourceManagerRetriever,
+ Executor executor,
+ MetricQueryServiceRetriever
metricQueryServiceRetriever) {
+ super(endpointConfiguration);
+ this.leaderRetriever =
Preconditions.checkNotNull(leaderRetriever);
+ this.clusterConfiguration =
Preconditions.checkNotNull(clusterConfiguration);
+ this.restConfiguration =
Preconditions.checkNotNull(restConfiguration);
+ this.resourceManagerRetriever =
Preconditions.checkNotNull(resourceManagerRetriever);
+ this.executor = Preconditions.checkNotNull(executor);
+
+ this.executionGraphCache = new ExecutionGraphCache(
+ restConfiguration.getTimeout(),
+
Time.milliseconds(restConfiguration.getRefreshInterval()));
+
+ this.checkpointStatsCache = new CheckpointStatsCache(
+
restConfiguration.getMaxCheckpointStatisticCacheEntries());
+
+ this.metricFetcher = new MetricFetcher<>(
+ leaderRetriever,
+ metricQueryServiceRetriever,
+ executor,
+ restConfiguration.getTimeout());
+ }
+
+ @Override
+ protected List<Tuple2<RestHandlerSpecification, ChannelInboundHandler>>
initializeHandlers(CompletableFuture<String> restAddressFuture) {
+ ArrayList<Tuple2<RestHandlerSpecification,
ChannelInboundHandler>> handlers = new ArrayList<>(3);
--- End diff --
Initial size of 3 for the `ArrayList` isn't right anymore.
> Start JobMasterRestEndpoint in JobClusterEntrypoint
> ---------------------------------------------------
>
> Key: FLINK-8030
> URL: https://issues.apache.org/jira/browse/FLINK-8030
> Project: Flink
> Issue Type: Sub-task
> Components: REST
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> We should launch the {{JobMasterRestEndpoint}} in the
> {{JobClusterEntrypoint}} in order to run the web frontend for per-job
> clusters.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
