[
https://issues.apache.org/jira/browse/FLINK-8029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283732#comment-16283732
]
ASF GitHub Bot commented on FLINK-8029:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4987#discussion_r155804733
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -757,6 +775,64 @@ public void heartbeatFromResourceManager(final
ResourceID resourceID) {
return
CompletableFuture.completedFuture(executionGraph.getState());
}
+
//----------------------------------------------------------------------------------------------
+ // RestfulGateway RPC methods
+
//----------------------------------------------------------------------------------------------
+
+ @Override
+ public CompletableFuture<String> requestRestAddress(Time timeout) {
+ return restAddressFuture;
+ }
+
+ @Override
+ public CompletableFuture<AccessExecutionGraph> requestJob(JobID jobId,
Time timeout) {
+ if (Objects.equals(jobGraph.getJobID(), jobId)) {
--- End diff --
When I see `Objects.equals`, I am assuming that it's possible that both
arguments can be null. However, `jobGraph.getJobID()` is always non-null.
> Create common WebMonitorEndpoint
> --------------------------------
>
> Key: FLINK-8029
> URL: https://issues.apache.org/jira/browse/FLINK-8029
> Project: Flink
> Issue Type: Sub-task
> Components: REST
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to reuse the existing the REST handlers, we should create a common
> {{WebMonitorEndpoint}} which is shared by the {{Dispatcher}} and the
> {{JobMaster}} component.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
