Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r156051769
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
@@ -44,7 +48,13 @@
private static volatile MetricRegistryConfiguration
defaultConfiguration;
// regex pattern to split the defined reporters
- private static final Pattern splitPattern =
Pattern.compile("\\s*,\\s*");
+ private static final Pattern reporterListPattern =
Pattern.compile("\\s*,\\s*");
+
+ // regex pattern to extract the name from reporter configuration keys,
e.g. "rep" from "metrics.reporter.rep.class"
+ private static final Pattern reporterClassPattern = Pattern.compile(
+ Pattern.quote(ConfigConstants.METRICS_REPORTER_PREFIX) +
+ "([\\S&&[^.]]*)\\." +
--- End diff --
of course, lacking documentation is the one gripe I always have when i find
a regex somewhere, and now i did that myself :(
---
