[
https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285809#comment-16285809
]
ASF GitHub Bot commented on FLINK-8080:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r156051769
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
@@ -44,7 +48,13 @@
private static volatile MetricRegistryConfiguration
defaultConfiguration;
// regex pattern to split the defined reporters
- private static final Pattern splitPattern =
Pattern.compile("\\s*,\\s*");
+ private static final Pattern reporterListPattern =
Pattern.compile("\\s*,\\s*");
+
+ // regex pattern to extract the name from reporter configuration keys,
e.g. "rep" from "metrics.reporter.rep.class"
+ private static final Pattern reporterClassPattern = Pattern.compile(
+ Pattern.quote(ConfigConstants.METRICS_REPORTER_PREFIX) +
+ "([\\S&&[^.]]*)\\." +
--- End diff --
of course, lacking documentation is the one gripe I always have when i find
a regex somewhere, and now i did that myself :(
> Remove need for "metrics.reporters"
> -----------------------------------
>
> Key: FLINK-8080
> URL: https://issues.apache.org/jira/browse/FLINK-8080
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, Metrics
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Trivial
> Fix For: 1.5.0
>
>
> Currently, in order to use a reporter one must configure something like this:
> {code}
> metrics.reporters: jmx
> metrics.reporter.jmx.class: ...
> {code}
> It would be neat if users did not have to set {{metrics.reporters}}. We can
> accomplish this by a scanning the configuration for configuration keys
> starting with {{metrics.reporter.}} and using the next word as a reporter
> name.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
