[
https://issues.apache.org/jira/browse/FLINK-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287458#comment-16287458
]
ASF GitHub Bot commented on FLINK-8238:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5153
[FLINK-8238][FLINK-8239] Extend StreamTaskTestHarness
## What is the purpose of the change
This PR extends the `StreamTaskTestHarness` to support
`TwoInputStreamOperators` as chain head operators, and adds a check that setup
is only called once.
## Verifying this change
The check that allows only allows 1 setup call is covered by a new test in
`StreamTaskTestHarnessTest`. The extension for `TwoInputStreamOperators` is
currently untested, but this was mostly an API thing and will be used for
testing FLINK-4812 (watermark metrics).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 8238
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5153
----
commit e48a0ac9273964e0ba841d24dc28c00981e5ca65
Author: zentol <[email protected]>
Date: 2017-12-11T14:26:55Z
[FLINK-8238][tests] Forbid multiple setups of StreamTaskTestHarness
commit 5da8233180beca2a555132b3386dba28d5b5ded1
Author: zentol <[email protected]>
Date: 2017-12-11T14:28:07Z
[FLINK-8239][tests] StreamTaskTestHarness supports 2-input head operators
----
> StreamTaskTestHarness should only allow one setup call
> ------------------------------------------------------
>
> Key: FLINK-8238
> URL: https://issues.apache.org/jira/browse/FLINK-8238
> Project: Flink
> Issue Type: Improvement
> Components: Streaming, Tests
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.5.0
>
>
> The {{StreamTaskTestHarness}} offers 2 methods for settting up an
> {{OperatorChain}}:
> * setupOutputForSingletonOperatorChain
> * setupOperatorChain
> We should add a check to make sure that only one of these methods is called.
> Calling both methods leads to undefined behavior by the task and is a bit
> tricky to debug.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
