[
https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287514#comment-16287514
]
ASF GitHub Bot commented on FLINK-4812:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5155
[FLINK-4812][metrics] Expose currentLowWatermark for all operators
Revised version of #5125, builds on #5154 and #5153. Only the last commit
is relevant for this PR.
## What is the purpose of the change
With this PR all operators expose the current input/output watermark
through the metric system.
Input watermarks for the head operator are measured in the
StreamInputProcessors.
Input watermarks for chained operators, and all output watermarks are
measured in the output of each operator.
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a
persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
This change added tests and can be verified as follows:
Run
* WatermarkGaugeTest
* MinWatermarkGaugeTest
* OneInputStreamTaskTest
* TwoInputStreamTaskTest
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: ( no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (yes
(per-watermark codepaths))
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 4812
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5155
----
commit 66a5ff27cd4b9b3fafb2b949fe624a50ec904e8c
Author: zentol <[email protected]>
Date: 2017-12-06T13:39:15Z
[FLINK-8213][metrics] Add safe dummy ComponentMetricGroups to flink-runtime
commit 13a0802bbd8b635820a40da80aef36ced5664aac
Author: zentol <[email protected]>
Date: 2017-12-06T13:06:55Z
[FLINK-8213][metrics] Add guards against ClassCastExceptions
commit 6e0be28d7f5c9d849b1b28bc9dd3935195a9cdb5
Author: zentol <[email protected]>
Date: 2017-12-06T13:56:20Z
[FLINK-8213][metrics] Replace usages of existing dummy groups
commit 5af3ea30922ee3163282f3f83432a14b89083a74
Author: zentol <[email protected]>
Date: 2017-12-06T13:59:09Z
[FLINK-8213][metrics] Replace usages of existing NoOpRegistry
commit c245269fff0653c5c6712603e92d77bd3e8ea07b
Author: zentol <[email protected]>
Date: 2017-12-06T13:59:18Z
[hotfix][metrics] Refactor CheckpointStatsTrackerTest
commit 46fd6f9b60ff2cff6a267c3a39af9683c64d3641
Author: zentol <[email protected]>
Date: 2017-12-11T14:26:55Z
[FLINK-8238][tests] Forbid multiple setups of StreamTaskTestHarness
commit e1a2b4e91a582f522fa0b33f24919ad04ac9ff45
Author: zentol <[email protected]>
Date: 2017-12-11T14:28:07Z
[FLINK-8239][tests] StreamTaskTestHarness supports 2-input head operators
commit 66cc83bccf17ab544510c25df42d48b370091eb9
Author: zentol <[email protected]>
Date: 2017-12-05T13:20:29Z
[FLINK-4812][metrics] Expose currentLowWatermark for all operators
----
> Report Watermark metrics in all operators
> -----------------------------------------
>
> Key: FLINK-4812
> URL: https://issues.apache.org/jira/browse/FLINK-4812
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Reporter: Robert Metzger
> Assignee: Chesnay Schepler
> Priority: Critical
> Fix For: 1.5.0
>
>
> As reported by a user, Flink does currently not export the current low
> watermark for sources
> (http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/currentLowWatermark-metric-not-reported-for-all-tasks-td13770.html).
> This JIRA is for adding such a metric for the sources as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
