[
https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287903#comment-16287903
]
ASF GitHub Bot commented on FLINK-8178:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5105#discussion_r156411078
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java
---
@@ -50,24 +51,15 @@
private final ByteBuffer lengthBuffer;
/** Current target {@link Buffer} of the serializer */
- private Buffer targetBuffer;
-
- /** Current {@link MemorySegment} of target buffer */
- private MemorySegment targetMemorySegment;
-
- /** Position in current {@link MemorySegment} of target buffer */
- private int position;
-
- /** Limit of current {@link MemorySegment} of target buffer */
- private int limit;
+ private BufferBuilder targetBuffer;
--- End diff --
should we mark this `@Nullable`?
> Introduce not threadsafe write only BufferBuilder
> -------------------------------------------------
>
> Key: FLINK-8178
> URL: https://issues.apache.org/jira/browse/FLINK-8178
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Fix For: 1.5.0
>
>
> While Buffer class is used in multithreaded context it requires
> synchronisation. Now it is miss-leading/unclear and suggesting that
> RecordSerializer should take into account synchronisation of the Buffer
> that's holding. With NotThreadSafe BufferBuilder there would be clear
> separation between single-threaded writing/creating a BufferBuilder and
> multithreaded Buffer handling/retaining/recycling.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
