Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5160#discussion_r156641501
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtilTest.java
---
@@ -131,6 +131,16 @@ public void testReplaceDeprecatedKeys() {
assertEquals("2",
replacedConfig.getProperty(KinesisConfigUtil.COLLECTION_MAX_COUNT));
}
+ @Test
+ public void testCorrectlySetRegionInProducerConfiguration() {
+ String region = "us-east-1";
+ Properties testConfig = new Properties();
+ testConfig.setProperty(AWSConfigConstants.AWS_REGION, region);
+ KinesisProducerConfiguration kpc =
KinesisConfigUtil.getValidatedProducerConfiguration(testConfig);
+
+ assertEquals("region not expected", region, kpc.getRegion());
--- End diff --
I think the error message is a bit misleading.
I think "incorrect region" will be enough here.
---
