[
https://issues.apache.org/jira/browse/FLINK-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289526#comment-16289526
]
ASF GitHub Bot commented on FLINK-7928:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4991#discussion_r156719388
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
---
@@ -52,6 +63,15 @@
/** How many native memory in mb are needed */
private final int nativeMemoryInMB;
+ /** A extensible field for user specified resources from {@link
ResourceSpec}. */
+ private final Map<String, Double> extendedResources = new TreeMap<>();
--- End diff --
Why is `extendedResources` of type `Map<String, Double` and not
`Map<String, Resource>`? I guess it's mostly because we no longer have to merge
`Resources`. But what happens if we want to combine multiple `ResourceProfiles`
because we want to launch a TM which contains multiple slots (each of them
having a single `ResourceProfile` assigned)?
> Extend the filed in ResourceProfile for precisely calculating the resource of
> a task manager
> --------------------------------------------------------------------------------------------
>
> Key: FLINK-7928
> URL: https://issues.apache.org/jira/browse/FLINK-7928
> Project: Flink
> Issue Type: Improvement
> Components: JobManager, ResourceManager
> Reporter: shuai.xu
> Assignee: shuai.xu
> Labels: flip-6
>
> ResourceProfile records all the resource requirements for a slot。It is
> generated by JobMaster and then passed to ResourceManager with the slot
> request.
> A task in the slot needs three parts of resource:
> 1. The resource for the operators, this is specified by the ResourceSpec user
> defined
> 2. The resource for the operators to communicating with their upstreams. For
> example, the resource for buffer pools and so on.
> 3. The resource for the operators to communicating with their downstreams.
> Same as above.
> So ResourceProfile should contain three parts of resource, the first part
> from ResouceSpec, and the other two part be generated by Job Master.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
