Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4991#discussion_r156719388
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
 ---
    @@ -52,6 +63,15 @@
        /** How many native memory in mb are needed */
        private final int nativeMemoryInMB;
     
    +   /** A extensible field for user specified resources from {@link 
ResourceSpec}. */
    +   private final Map<String, Double> extendedResources = new TreeMap<>();
    --- End diff --
    
    Why is `extendedResources` of type `Map<String, Double` and not 
`Map<String, Resource>`? I guess it's mostly because we no longer have to merge 
`Resources`. But what happens if we want to combine multiple `ResourceProfiles` 
because we want to launch a TM which contains multiple slots (each of them 
having a single `ResourceProfile` assigned)?


---

Reply via email to