[ 
https://issues.apache.org/jira/browse/FLINK-8089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290554#comment-16290554
 ] 

ASF GitHub Bot commented on FLINK-8089:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5090#discussion_r156882122
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolTest.java 
---
    @@ -383,6 +386,76 @@ public void 
testSlotRequestCancellationUponFailingRequest() throws Exception {
                }
        }
     
    +   /**
    +    * Tests that unused offered slots are directly used to fulfil pending 
slot
    --- End diff --
    
    True, will use the american version


> Fulfil slot requests with unused offered slots
> ----------------------------------------------
>
>                 Key: FLINK-8089
>                 URL: https://issues.apache.org/jira/browse/FLINK-8089
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>
> The {{SlotPool}} adds unused offered slots to the list of available slots 
> without checking whether another pending slot request could be fulfilled with 
> this slot. This should be changed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to