[
https://issues.apache.org/jira/browse/FLINK-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294515#comment-16294515
]
ASF GitHub Bot commented on FLINK-8218:
---------------------------------------
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5131
Thanks, +1 LGTM.
Merging this ...
> move flink-connector-kinesis examples from /src to /test
> --------------------------------------------------------
>
> Key: FLINK-8218
> URL: https://issues.apache.org/jira/browse/FLINK-8218
> Project: Flink
> Issue Type: Improvement
> Components: Kinesis Connector
> Affects Versions: 1.5.0
> Reporter: Bowen Li
> Assignee: Bowen Li
> Priority: Minor
> Fix For: 1.5.0
>
>
> I just saw there are runnable examples in src tree and traced back to this
> PR. I feel it's really bad to have runnable examples (with java main method)
> in a lib jar that Flink distributes.
> chatted with [~tzulitai] , we agreed that we should move those examples from
> /src to /test
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
