Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5168#discussion_r157481165
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java 
---
    @@ -357,6 +362,28 @@ public void start() throws Exception {
                return 
CompletableFuture.completedFuture(jobManagerServices.blobServer.getPort());
        }
     
    +   @Override
    +   public CompletableFuture<Either<Throwable, 
SerializedJobExecutionResult>> getJobExecutionResult(
    --- End diff --
    
    I fear we cannot directly use a `Throwable` here, because it might be a 
user defined throwable. Therefore, we have to use `SerializedThrowable` instead.


---

Reply via email to