[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

[GJL]

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5184#discussion_r157877406
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java
 ---
    @@ -458,7 +465,14 @@ public JobExecutionResult getResult() throws 
JobExecutionException, InterruptedE
                                }
                        }
                        else if (result != null) {
    -                           return result;
    +                           try {
    +                                   return new SerializedJobExecutionResult(
    +                                           jobId,
    +                                           result.getNetRuntime(),
    +                                           
result.getAccumulatorResults()).toJobExecutionResult(ClassLoader.getSystemClassLoader());
    --- End diff --
    
    Because the exception is serialized in 
`OnCompletionActions#jobFailed(JobExecutionResult);`, I have to deserialize it 
here again. I wonder if this is sane?
    
    CC: @tillrohrmann 


---