[ https://issues.apache.org/jira/browse/FLINK-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301773#comment-16301773 ]
ASF GitHub Bot commented on FLINK-8037: --------------------------------------- GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/5205 [FLINK-8037] Fix integer multiplication or shift implicitly cast to long ## What is the purpose of the change Fixes potential overflow flagged by the IntelliJ inspection "Integer multiplication or shift implicitly cast to long". ## Brief change log - mark integer literal as long - cast multiplied integer to long ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no)** - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented) You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 8037_fix_integer_multiplication_or_shift_implicitly_cast_to_long Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5205.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5205 ---- commit ec2f80c5e890dc52b715eeca719c911aaa75fb82 Author: Greg Hogan <code@...> Date: 2017-12-21T17:45:54Z [FLINK-8037] Fix integer multiplication or shift implicitly cast to long ---- > Missing cast in integer arithmetic in > TransactionalIdsGenerator#generateIdsToAbort > ---------------------------------------------------------------------------------- > > Key: FLINK-8037 > URL: https://issues.apache.org/jira/browse/FLINK-8037 > Project: Flink > Issue Type: Bug > Reporter: Ted Yu > Assignee: Greg Hogan > Priority: Minor > > {code} > public Set<String> generateIdsToAbort() { > Set<String> idsToAbort = new HashSet<>(); > for (int i = 0; i < safeScaleDownFactor; i++) { > idsToAbort.addAll(generateIdsToUse(i * poolSize * > totalNumberOfSubtasks)); > {code} > The operands are integers where generateIdsToUse() expects long parameter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)