[
https://issues.apache.org/jira/browse/FLINK-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305890#comment-16305890
]
ASF GitHub Bot commented on FLINK-8324:
---------------------------------------
GitHub user tony810430 opened a pull request:
https://github.com/apache/flink/pull/5214
[FLINK-8324] [kafka] Expose another offsets metrics by using new metric API
to specify user defined variables
## What is the purpose of the change
Add two metrics for current offsets and committed offsets by using new
metric API, which can define user scope variables.
## Brief change log
- add two metrics for current offsets and committed offsets
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not documented
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tony810430/flink FLINK-8324
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5214.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5214
----
commit 76675d5e3fdcc023142724838eeddc1c2029e120
Author: Tony Wei <tony19920430@...>
Date: 2017-12-28T02:19:24Z
[FLINK-8324] Expose another offsets metrics by using new metric API to
specify user defined variables
----
> Expose another offsets metrics by using new metric API to specify user
> defined variables
> ----------------------------------------------------------------------------------------
>
> Key: FLINK-8324
> URL: https://issues.apache.org/jira/browse/FLINK-8324
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
> Reporter: Wei-Che Wei
> Assignee: Wei-Che Wei
> Priority: Trivial
> Fix For: 1.5.0
>
>
> The {{current-offsets}} and {{committed-offsets}} metrics are now attached
> with topic name and partition id in the metric identity.
> It is not convenient to use these metrics in Prometheus, because user usually
> uses the same metric group name to group by those metrics which have the same
> meaning and uses tags to get the individual metric.
> For example, I will prefer to access {{current-offsets}} metric group and use
> {{partition-x}} tag to get the offset of partition x, instead of getting
> metric directly from {{current-offsets-partition-x}} metric.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
