[
https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307217#comment-16307217
]
ASF GitHub Bot commented on FLINK-8331:
---------------------------------------
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5218
@fhueske thanks for your explanation, make sense to me. I updated the PR.
The changes as follows:
- Revert the change of `RowCsvInputFormatTest.testTailingEmptyFields`.
- Unity parseField behavior when startPos = limit, except StringParser,
that is `StringParser` set error state `EMPTY_COLUMN` and set empty string to
`result`,return `limit` value as index, and other set error state
`EMPTY_COLUMN`, return `-1` as index;
Best, Jincheng
> FieldParsers do not correctly set EMPT_COLUMN error state
> ---------------------------------------------------------
>
> Key: FLINK-8331
> URL: https://issues.apache.org/jira/browse/FLINK-8331
> Project: Flink
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.5.0, 1.4.1
> Reporter: Fabian Hueske
> Assignee: sunjincheng
>
> Some {{FieldParser}} do not correctly set the EMPTY_COLUMN error state if a
> field is empty.
> Instead, they try to parse the field value from an empty String which fails,
> e.g., in case of the {{DoubleParser}} with a {{NumberFormatException}}.
> The {{RowCsvInputFormat}} has a flag to interpret empty fields as {{null}}
> values. The implementation requires that all {{FieldParser}} correctly return
> the EMPTY_COLUMN error state in case of an empty field.
> Affected {{FieldParser}}:
> - BigDecParser
> - BigIntParser
> - DoubleParser
> - FloatParser
> - SqlDateParser
> - SqlTimeParser
> - SqlTimestampParser
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
