GitHub user okumin opened a pull request:

    https://github.com/apache/flink/pull/5221

    [hotfix] [docs] Format Scala programs in docs

    *Thank you very much for contributing to Apache Flink - we are happy that 
you want to help us improve Flink. To help the community review your 
contribution in the best possible way, please go through the checklist below, 
which will get the contribution into a shape in which it can be best reviewed.*
    
    *Please understand that we do not do this to make contributions to Flink a 
hassle. In order to uphold a high standard of quality for code contributions, 
while at the same time managing a large number of contributions, we need 
contributors to prepare the contributions well, and give reviewers enough 
contextual information for the review. Please also understand that 
contributions that do not follow this guide will take longer to review and thus 
typically be picked up with lower priority by the community.*
    
    
    
    * remove unneeded semi-colons
    * add `()` to `print` method
        * typically, methods with some side-effects are invoked with `()`
    * replace some Java codes in Scala examples into Scala codes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/okumin/flink format-scala-code

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5221
    
----
commit 96521134a0b0ac2be0b8afc7b1c01a0a0c18fe09
Author: okumin <mail@...>
Date:   2018-01-01T06:25:54Z

    Format Scala programs in docs
    
    * remove unneeded semi-colons
    * add `()` to `print` method
        * typically, methods with some side-effects are invoked with `()`
    * replace some Java codes in Scala examples into Scala codes

----


---

Reply via email to