[GitHub] flink issue #5140: [FLINK-7797] [table] Add support for windowed outer joins...

[xccui]

Github user xccui commented on the issue:

    https://github.com/apache/flink/pull/5140
  
    Hi @fhueske, thanks for your review. I've made the following changes to the 
PR.
    1. Fixes the "wrong sides" problem in `TimeBoundedStreamJoin`.
    2. Adds the logic for outer-joins with negative window size in 
`DataStreamWindowJoin`.
    3. Refines the `EmitAwareCollector` according to your suggestions.
    4. Uses a separate class `OuterJoinPaddingUtil` to deal with results 
padding.
    5. Adds some test cases to `JoinITCase` and `JoinHarnessTest`.
    6. Other minor changes to attribute/method/class names.
    
    Thanks, Xingcan


---