[
https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308035#comment-16308035
]
ASF GitHub Bot commented on FLINK-8345:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/5230#discussion_r159222752
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
---
@@ -586,7 +586,7 @@ private StreamGraph
generateInternal(List<StreamTransformation<?>> transformatio
transform.getOutputType(),
transform.getName());
- if (transform.getStateKeySelector1() != null) {
+ if (transform.getStateKeySelector1() != null ||
transform.getStateKeySelector2() != null) {
--- End diff --
Do we still need the check here or will the code work if we set either to
`null`? I think it does because in the broadcast case we set the second key
selector to `null`.
> Iterate over keyed state on broadcast side of connect with broadcast.
> ---------------------------------------------------------------------
>
> Key: FLINK-8345
> URL: https://issues.apache.org/jira/browse/FLINK-8345
> Project: Flink
> Issue Type: New Feature
> Components: Streaming
> Affects Versions: 1.5.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)