Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5193#discussion_r159238089
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
 ---
    @@ -98,7 +99,13 @@
        // late arriving event OutputTag<StreamRecord<IN>>
        private static final OutputTag<Tuple2<String, Integer>> lateOutputTag = 
new OutputTag<Tuple2<String, Integer>>("late-output") {};
     
    -   private void 
testSlidingEventTimeWindows(OneInputStreamOperatorTestHarness<Tuple2<String, 
Integer>, Tuple2<String, Integer>> testHarness) throws Exception {
    +   private void 
testSlidingEventTimeWindows(OneInputStreamOperator<Tuple2<String, Integer>, 
Tuple2<String, Integer>> operator) throws Exception {
    --- End diff --
    
    Yes. Previously restoring tests were working on `closed` harness, which was 
working only because test harness it self wasn't properly closing itself 🙄 


---

Reply via email to