Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4963#discussion_r159387626
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java
 ---
    @@ -497,6 +497,15 @@ public String toString() {
     
                        return partitionOffsets;
                }
    +
    +           @Override
    +           public void update(List<S> values) throws Exception {
    +                   internalList.clear();
    +
    +                   if (values != null && !values.isEmpty()) {
    --- End diff --
    
    nit: I think the second check is not required and makes the statement more 
verbose for no good reason.


---

Reply via email to