Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5220#discussion_r159446300
  
    --- Diff: 
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java
 ---
    @@ -99,6 +69,44 @@ public void testStop() throws Exception {
                }
        }
     
    +   @Test(expected = CliArgsException.class)
    +   public void testUnrecognizedOption() throws Exception {
    +           // test unrecognized option
    +           String[] parameters = { "-v", "-l" };
    +           CliFrontend testFrontend = new 
CliFrontend(CliFrontendTestUtils.getConfigDir());
    +           testFrontend.stop(parameters);
    +
    +           fail("Should have failed.");
    +   }
    +
    +   @Test(expected = CliArgsException.class)
    --- End diff --
    
    nit: Test could be stricter by asserting that the exception carries the 
expected message.
      


---

Reply via email to